Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve the issue of generated titles missing id #4997

Merged
merged 2 commits into from
Dec 7, 2023
Merged

fix: resolve the issue of generated titles missing id #4997

merged 2 commits into from
Dec 7, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Dec 5, 2023 •
edited by ruibaby
Loading

What type of PR is this?

/kind bug
/area console
/milestone 2.12.x

What this PR does / why we need it:

在 #4975 中，使用 decorations 重写了 heading，但由于 decorations 只会给 nodeview 增加 id，因此会导致 render 后的 html 中不存在 id。
默认编辑器 heading 渲染时，自动增加 id。

How to test it?

使用默认编辑器编辑时，增加 Heading。保存后查看主题端对应的 heading 是否存在 id。

Which issue(s) this PR fixes:

Fixes #4994

Does this PR introduce a user-facing change?

修复文章渲染后内容中标题不存在 id 的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Dec 5, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Dec 5, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and ruibaby December 5, 2023 09:52
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Dec 5, 2023
@LIlGG
Copy link
Member Author

LIlGG commented Dec 5, 2023

/cherry-pick release-2.11

@halo-dev-bot
Copy link
Collaborator

@LIlGG: once the present PR merges, I will cherry-pick it on top of release-2.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (197c622) 55.94% compared to head (aabd853) 55.94%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #4997   +/-   ##
=========================================
  Coverage     55.94%   55.94%           
  Complexity     3034     3034           
=========================================
  Files           525      525           
  Lines         17816    17816           
  Branches       1329     1329           
=========================================
  Hits           9967     9967           
  Misses         7300     7300           
  Partials        549      549

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LIlGG LIlGG mentioned this pull request Dec 5, 2023
Closed
ruibaby
ruibaby reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
@ruibaby
Copy link
Member

ruibaby commented Dec 6, 2023

/cherry-pick release-2.11

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

guqing
guqing reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

ruibaby
ruibaby approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 1f5bef7 into halo-dev:main Dec 7, 2023
4 checks passed
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #5009

In response to this:

/cherry-pick release-2.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@halo-dev-bot halo-dev-bot mentioned this pull request Dec 7, 2023
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request Dec 7, 2023
@halo-dev-bot
[release-2.11] fix: resolve the issue of generated titles missing id (#…
97b5f72 
…5009)

This is an automated cherry-pick of #4997

/assign ruibaby

```release-note
解决渲染后的 Heading 中不存在 id 的问题。
```
@LIlGG LIlGG mentioned this pull request Dec 22, 2023
Closed
@JohnNiang JohnNiang modified the milestones: 2.12.x, 2.12.0 Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@ruibaby ruibaby ruibaby approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees

@ruibaby ruibaby

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

新创建的文章无法通过目录到文章对应位置
5 participants
@LIlGG @halo-dev-bot @ruibaby @guqing @JohnNiang